Avoid unnecessary byte/string conversion#1049
Merged
coreybutler merged 1 commit intocoreybutler:masterfrom Oct 10, 2023
Juneezee:master
Merged
Avoid unnecessary byte/string conversion#1049coreybutler merged 1 commit intocoreybutler:masterfrom Juneezee:master
coreybutler merged 1 commit intocoreybutler:masterfrom
Juneezee:master
Conversation
We can use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` to avoid unnecessary `[]byte`
conversions and reduce allocations.
Example benchmark:
func BenchmarkMatch(b *testing.B) {
reg, _ := regexp.Compile("[^0-9]")
for i := 0; i < b.N; i++ {
if match := reg.Match([]byte("v")); !match {
b.Fail()
}
}
}
func BenchmarkMatchString(b *testing.B) {
reg, _ := regexp.Compile("[^0-9]")
for i := 0; i < b.N; i++ {
if match := reg.MatchString("v"); !match {
b.Fail()
}
}
}
BenchmarkMatch-16 19712776 65.47 ns/op 1 B/op 1 allocs/op
BenchmarkMatchString-16 24261463 51.16 ns/op 0 B/op 0 allocs/op
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
coreybutler
approved these changes
Oct 10, 2023
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use
(*regexp.Regexp).MatchStringinstead of(*regexp.Regexp).Match([]byte(...))to avoid unnecessary[]byteconversions and reduce allocations. A one-line change for free performance gain.Benchmark:
Result: