Add support for IBMCloud/PowerVS images#16
Merged
bgilbert merged 4 commits intocoreos:mainfrom Nov 4, 2021
Merged
Conversation
Contributor
|
I know we haven't generalized the AWS image struct in the Rust bindings, but we should probably avoid compounding the mistake, and go with |
Contributor
Author
yes that makes sense. done. |
bgilbert
reviewed
Nov 2, 2021
Adding support for IBMCloud/PowerVS objects to be added to the stream. similar to coreos/stream-metadata-go#35
bgilbert
approved these changes
Nov 4, 2021
Contributor
bgilbert
left a comment
There was a problem hiding this comment.
LGTM; just some wording suggestions.
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
28 tasks
29 tasks
26 tasks
44 tasks
44 tasks
44 tasks
45 tasks
45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for IBMCloud/PowerVS objects to be added to the stream.
similar to coreos/stream-metadata-go#35