address go lint checks

dustymabe · dustymabe · commit c021cbaad060 · 2025-07-18T16:18:29.000-04:00
```
  Error: fedoracoreos/fcos.go:39:17: Error return value of `resp.Body.Close` is not checked (errcheck)
  	resp.Body.Close()
  	               ^
  Error: stream/artifact_utils.go:22:23: Error return value of `resp.Body.Close` is not checked (errcheck)
  	defer resp.Body.Close()
  	                     ^
  Error: example/example.go:28:10: ST1005: error strings should not be capitalized (staticcheck)
  		return fmt.Errorf("Failed to download %s: %w", iso.Location, err)
  		       ^
  Error: example/example.go:38:10: ST1005: error strings should not be capitalized (staticcheck)
  		return fmt.Errorf("No %s architecture in stream", targetArch)
  		       ^
  Error: example/example.go:42:10: ST1005: error strings should not be capitalized (staticcheck)
  		return fmt.Errorf("No %s AWS images in stream", targetArch)
  		       ^
  Error: example/example.go:62:2: QF1003: could use tagged switch on arg (staticcheck)
  	if arg == "aws-ami" {
  	^
```
diff --git a/example/example.go b/example/example.go
@@ -25,7 +25,7 @@ func downloadISO(fcosstable stream.Stream) error {
 	fmt.Printf("Downloading %s\n", iso.Location)
 	path, err := iso.Download(".")
 	if err != nil {
-		return fmt.Errorf("Failed to download %s: %w", iso.Location, err)
+		return fmt.Errorf("failed to download %s: %w", iso.Location, err)
 	}
 	fmt.Printf("Downloaded %s\n", path)
 
@@ -35,15 +35,15 @@ func downloadISO(fcosstable stream.Stream) error {
 func printAMI(fcosstable stream.Stream) error {
 	arch, ok := fcosstable.Architectures[targetArch]
 	if !ok {
-		return fmt.Errorf("No %s architecture in stream", targetArch)
+		return fmt.Errorf("no %s architecture in stream", targetArch)
 	}
 	awsimages := arch.Images.Aws
 	if awsimages == nil {
-		return fmt.Errorf("No %s AWS images in stream", targetArch)
+		return fmt.Errorf("no %s AWS images in stream", targetArch)
 	}
 	var regionVal stream.SingleImage
 	if regionVal, ok = awsimages.Regions[region]; !ok {
-		return fmt.Errorf("No %s AWS images in region %s", targetArch, region)
+		return fmt.Errorf("no %s AWS images in region %s", targetArch, region)
 	}
 	fmt.Printf("%s\n", regionVal.Image)
 
@@ -59,11 +59,12 @@ func run() error {
 	if err != nil {
 		return err
 	}
-	if arg == "aws-ami" {
+	switch arg {
+	case "aws-ami":
 		return printAMI(*fcosstable)
-	} else if arg == "download-iso" {
+	case "download-iso":
 		return downloadISO(*fcosstable)
-	} else {
+	default:
 		return fmt.Errorf("invalid operation %s", arg)
 	}
 }
diff --git a/fedoracoreos/fcos.go b/fedoracoreos/fcos.go
@@ -36,7 +36,10 @@ func getStream(u url.URL) (*stream.Stream, error) {
 		return nil, err
 	}
 	body, err := io.ReadAll(resp.Body)
-	resp.Body.Close()
+	if err != nil {
+		return nil, err
+	}
+	err = resp.Body.Close()
 	if err != nil {
 		return nil, err
 	}
diff --git a/stream/artifact_utils.go b/stream/artifact_utils.go
@@ -2,6 +2,7 @@ package stream
 
 import (
 	"crypto/sha256"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -19,7 +20,9 @@ func (a *Artifact) Fetch(w io.Writer) error {
 	if err != nil {
 		return err
 	}
-	defer resp.Body.Close()
+	defer func() {
+		err = errors.Join(resp.Body.Close())
+	}()
 
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("%s returned status: %s", a.Location, resp.Status)

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,10 @@ func getStream(u url.URL) (*stream.Stream, error) {`
`36`	`36`	`return nil, err`
`37`	`37`	`}`
`38`	`38`	`body, err := io.ReadAll(resp.Body)`
`39`		`- resp.Body.Close()`
	`39`	`+ if err != nil {`
	`40`	`+ return nil, err`
	`41`	`+ }`
	`42`	`+ err = resp.Body.Close()`
`40`	`43`	`if err != nil {`
`41`	`44`	`return nil, err`
`42`	`45`	`}`