aws: get region after getting config#828
Merged
ajeddeloh merged 2 commits intocoreos:masterfrom Jul 19, 2019
Merged
Conversation
added 2 commits
July 16, 2019 14:11
Allow each provider's FetchConfig function to mutate the provider it uses. This will allow the aws platform to set the region after it has fetched the config.
We try to set the region as soon as Ignition starts, but sometimes the metadata server isn't accessible yet. Set the region after we've fetched the config since the server must be up by then.
arithx
approved these changes
Jul 16, 2019
Contributor
arithx
left a comment
There was a problem hiding this comment.
LGTM assuming it passes kola tests.
lucab
approved these changes
Jul 17, 2019
cgwalters
approved these changes
Jul 19, 2019
Contributor
Author
|
Tested with kola, confirmed it can still fetch the config. Given that I can't repro the original bug's environment to trigger the bug, that is still untested, but I'm fairly confident this should fix it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #826
should be backported to spec2x once merged