providers: support for Proxmox VE (continuation)#1910
Conversation
jlebon
left a comment
There was a problem hiding this comment.
Thanks! Some minor docs-related comments, but LGTM otherwise.
Were you able to test this?
|
Also, minor/optional: let's squash it all to one commit (and add yourself as co-author) ? |
Co-authored-by: bri <284789+b-@users.noreply.github.com>
|
I tested this PR and it seems to work fine in various situations. I patched the release notes and added Promox VE to supported platforms. I also squashed the PR to a single commit. |
|
@jlebon would you be so kind as to have a look ? |
|
Awesome! 🚀 |
|
Exciting ❤️ |
|
Can any of you elaborate on how to put this to use? I am new to FCOS & ignition and may simply not know where I should be looking. Thanks! |
|
@genebean If you're interested in using this in FCOS, the larger effort is tracked in coreos/fedora-coreos-tracker#736 and coreos/fedora-coreos-tracker#1652. |
|
Hi, do we know when a version will include this cool feature? |
Hello, this PR is a continuation of #1790. The original PR is doing good, but we cannot push to it and we would like things to go faster so we decided to make another one to finish it.
This PR includes the commit from @b-, and a fix for #1790 (comment). I also added release note.
I think this is good to go. Feel free to tell me otherwise.