Merged
Conversation
When establishing a network connection random port selection from the Kernel for local address is enough in 99.9% of the case. For the 0.1%, let's add a way to customize the local port used. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
0d427b8 to
12c882c
Compare
prestist
reviewed
Feb 2, 2024
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
Collaborator
There was a problem hiding this comment.
Just a small nit, would it be possible to describe how scale way is fetching the data in a comment above. similar to how it was done here.
prestist
approved these changes
Feb 2, 2024
Collaborator
prestist
left a comment
There was a problem hiding this comment.
Thank you for putting this together. Just a super small nit, but otherwise LGTM!
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
12c882c to
ce0bf8c
Compare
jlebon
approved these changes
Feb 7, 2024
Member
jlebon
left a comment
There was a problem hiding this comment.
Some comments, but LGTM as is too. We can always tweak those things in a follow-ups.
Thanks for the patch!
Member
|
Right gotcha. I misread the code here and thought we were retrying the same port in a loop. But we're clearly generating a new port number each time. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR we add the support for Scaleway cloud provider. Locally tested on Flatcar + Scaleway:
While it's a regular IMDS endpoint, it has a small difference with other providers:
I decided to go with a new
FetchOptioncalledLocalPortand to override the defaultDialContext.Related to: coreos/fedora-coreos-tracker#866