Add support for Azure gen2 VMs#1241
Merged
sohankunkerkar merged 3 commits intocoreos:mainfrom Jul 28, 2021
Merged
Conversation
sohankunkerkar
commented
Jul 1, 2021
bgilbert
reviewed
Jul 1, 2021
8caf981 to
bf0bb42
Compare
bgilbert
reviewed
Jul 12, 2021
c2a9a80 to
48c7949
Compare
bgilbert
reviewed
Jul 14, 2021
48c7949 to
dc7c852
Compare
bgilbert
reviewed
Jul 22, 2021
This change adds a blkid API to query block devices based on the particular filesystem.
dc7c852 to
15beeb9
Compare
bgilbert
reviewed
Jul 23, 2021
Contributor
bgilbert
left a comment
There was a problem hiding this comment.
This looks better. 👍 The retry logic just needs a bit more adjustment.
f7be440 to
0d3b0a1
Compare
Fixes coreos#1194 This change uses the same devicepath for gen1 and gen2 VMs because they can't easily be distinguished at runtime.
Azure was the only user of `DiskByIDDir` and since we're using the different approach to get the device details for azure instances, this code is not required anymore.
0d3b0a1 to
1cff42c
Compare
This was referenced Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1194
This patch adds support for Azure gen2 VMs in Ignition. For the safer side, this PR also handles a case where a bunch of block devices has the
FSTYPEset toudf, and accordingly, pick the right device that has an ignition config.With gen2 settings: