Skip to content

kola/tests: add openshift tag to OCP tests#3741

Merged
jlebon merged 1 commit intocoreos:mainfrom
jlebon:pr/ocp-tests
Mar 6, 2024
Merged

kola/tests: add openshift tag to OCP tests#3741
jlebon merged 1 commit intocoreos:mainfrom
jlebon:pr/ocp-tests

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Feb 21, 2024

This is part of openshift/os#1445.

Those tests are all actually testing OCP components. In the new model,
they should be run against an OCP layered image instead. Add a tag on
them so that we'll be able to run them separately.

@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlebon
Copy link
Member Author

jlebon commented Feb 21, 2024

Before doing this, we need to tweak things so that those tests keep running in the !layered streams. (A "layered stream" here refers to a stream built using the approach in openshift/os#1445).

Edit: I've changed the approach here to be more incremental: we still add an openshift tag, but it's no longer a RequiredTag, so should have no effect on current streams.

This is part of openshift/os#1445.

Those tests are all actually testing OCP components. In the new model,
they should be run against an OCP layered image instead. Add a tag on
them so that we'll be able to run them separately.
@jlebon jlebon changed the title kola/tests: add openshift required tag to OCP tests kola/tests: add openshift tag to OCP tests Mar 5, 2024
@jlebon jlebon marked this pull request as ready for review March 5, 2024 04:29
@jlebon
Copy link
Member Author

jlebon commented Mar 5, 2024

/retest

@jlebon
Copy link
Member Author

jlebon commented Mar 5, 2024

This is now ready for review!

Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One question, out of curiosity: Will it become a required tag in the future?

@jlebon
Copy link
Member Author

jlebon commented Mar 6, 2024

LGTM!

One question, out of curiosity: Will it become a required tag in the future?

Thanks for reviewing! Yes, probably. Once we've fully switched over to the new stream, then it becomes easier in the pipelines to use required tags so that the kola run on the base compose doesn't have to do --tag !openshift anymore.

@jlebon jlebon merged commit fd56e40 into coreos:main Mar 6, 2024
@jlebon jlebon deleted the pr/ocp-tests branch March 6, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants