oscontainer: Handle being run without a cosa build#1670
Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom Aug 20, 2020
Merged
oscontainer: Handle being run without a cosa build#1670openshift-merge-robot merged 1 commit intocoreos:masterfrom
openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
I'm working on synthesizing an update from an existing oscontainer and doing that I don't have a cosa build for it handy. If we don't find a `builds.json`, assume we're not in a cosa directory and skip adding the metadata.
jlebon
approved these changes
Aug 20, 2020
Comment on lines
+202
to
+203
| if os.path.isfile('builds/builds.json'): | ||
| with open('builds/builds.json') as fb: |
Member
There was a problem hiding this comment.
This is fine, though the $compiled_language programmer in me wants to do
try:
with open(...) as fb:
...
except FileNotFoundError:
pass
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on synthesizing an update from an existing oscontainer
and doing that I don't have a cosa build for it handy.
If we don't find a
builds.json, assume we're not in a cosadirectory and skip adding the metadata.