proxmoxve: do not fail if the config drive does not exist#1128
Merged
prestist merged 3 commits intocoreos:mainfrom Dec 3, 2024
Merged
proxmoxve: do not fail if the config drive does not exist#1128prestist merged 3 commits intocoreos:mainfrom
prestist merged 3 commits intocoreos:mainfrom
Conversation
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
fce6d96 to
587cbbc
Compare
prestist
approved these changes
Dec 3, 2024
Contributor
prestist
left a comment
There was a problem hiding this comment.
LGTM, I dont see anything that needs changes.
Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProxmoxVE provider will fail to be created if the config drive is not available. In this PR, we add a NoopProvider that is being used in such a case to avoid Afterburn to panic.
This has been tested on Flatcar (flatcar/Flatcar#1573 (reply in thread))
Closes: #1126