providers/hetzner: private ipv4 addresses in attributes#1094
Merged
travier merged 1 commit intocoreos:mainfrom Jul 23, 2024
Merged
providers/hetzner: private ipv4 addresses in attributes#1094travier merged 1 commit intocoreos:mainfrom
travier merged 1 commit intocoreos:mainfrom
Conversation
Adds new attributes `AFTERBURN_HETZNER_PRIVATE_IPV4_*` set to the servers IPv4 addresses in private networks. This is useful for e.g. discovery of etcd members that should communicate over the private network. Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
3806655 to
0de46d6
Compare
Contributor
|
For information, it has been successfully tried on Flatcar: |
travier
approved these changes
Jul 23, 2024
Member
travier
left a comment
There was a problem hiding this comment.
This LGTM. I have not tested it however.
Member
|
Thanks @tormath1 ! |
Member
|
and thanks @apricote for the PR 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new attributes
AFTERBURN_HETZNER_PRIVATE_IPV4_*set to the servers IPv4 addresses in private networks.This is useful for e.g. discovery of etcd members that should communicate over the private network.
I do not really know Rust well, so please take a closer look at the code :)