Skip to content

Fix HPA configuration #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hagaibarel merged 3 commits into from
Apr 1, 2023
Merged

Fix HPA configuration #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88c3332
Add condition to not define replica key on deployment when hpa is ena…
ligol Mar 31, 2023
dfffc12
Fix some issue and inconsistency about HPA configuration on value.yaml
ligol Mar 31, 2023
0880f2b
Upgrade chart.yaml
ligol Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions charts/coredns/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.20.1
version: 1.20.2
appVersion: 1.9.4
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand All @@ -19,9 +19,5 @@ engine: gotpl
type: application
annotations:
artifacthub.io/changes: |
- kind: changed
description: Use chart appVersion as default image tag
- kind: added
description: Add HagaiBarel as chart maintainer
- kind: fixed
description: Fix reference link to values file in the readme
description: Fix HPA configuration
2 changes: 1 addition & 1 deletion charts/coredns/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ metadata:
{{- end }}
{{- end }}
spec:
{{- if not .Values.autoscaler.enabled }}
{{- if and (not .Values.autoscaler.enabled) (not .Values.hpa.enabled) }}
replicas: {{ .Values.replicaCount }}
{{- end }}
strategy:
Expand Down
37 changes: 21 additions & 16 deletions charts/coredns/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,6 @@ resources:
cpu: 100m
memory: 128Mi

## Create HorizontalPodAutoscaler object.
##
# autoscaling:
# minReplicas: 1
# maxReplicas: 10
# metrics:
# - type: Resource
# resource:
# name: cpu
# targetAverageUtilization: 60
# - type: Resource
# resource:
# name: memory
# targetAverageUtilization: 60

rollingUpdate:
maxUnavailable: 1
maxSurge: 25%
Expand Down Expand Up @@ -254,7 +239,27 @@ customLabels: {}
customAnnotations: {}

## Alternative configuration for HPA deployment if wanted
#
## Create HorizontalPodAutoscaler object.
##
# hpa:
# enabled: false
# minReplicas: 1
# maxReplicas: 10
# metrics:
# metrics:
# - type: Resource
# resource:
# name: memory
# target:
# type: Utilization
# averageUtilization: 60
# - type: Resource
# resource:
# name: cpu
# target:
# type: Utilization
# averageUtilization: 60

hpa:
enabled: false
minReplicas: 1
Expand Down