plugin/dnssec: fix bogus RRSIGs for out-of-zone CNAME targets#8138
Merged
Conversation
…the query zone Signed-off-by: Björn Kinscher <code@bjoern-kinscher.de>
yongtang
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
The DNSSEC signer signs every RRset in a response with the zone matched
from the query name. When a CNAME points to a target outside the served
zone(s), the target's records were signed with our key. Validators reject
these as bogus.
This PR makes the Sign() function check first whether the target is outside
the served zone(s).
2. Which issues (if any) are related?
This was already adressed in #3891 but the fix was incomplete.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No.