fix: use descriptive error for unknown block options in health and log#8128
Merged
yongtang merged 1 commit intoMay 27, 2026
Merged
Conversation
…g plugins Signed-off-by: immanuwell <pchpr.00@list.ru>
yongtang
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you typo a block option in
healthorlog, the error you get back is kinda useless:That's
c.ArgErr(), which is meant for wrong arg counts -- not unknown properties. So the user has no clue what's actually wrong.Reproduce:
or
Both silently give a misleading error instead of saying "hey, that option doesn't exist".
Fix: swap
c.ArgErr()forc.Errf("unknown property '%s'", c.Val())in the default cases of those two setup parsers, same as was done in #8119, #8120, #8121.After fix: