fix(azure): apply access mode to every zone in the same block#8110
Merged
Conversation
`access private` was silently honored only for the last zone in an `azure RG:ZONE` block. The earlier zones retained the default `public` mode and were queried against the wrong Azure API, returning empty or stale data without any error or warning. This affects the canonical multi-zone example shown in the README. The cause was a pair of function-scoped `resourceGroup`/`zoneName` variables that the args loop overwrites on each iteration. The `access` handler then keyed `accessMap` by whatever value happened to be left behind. The per-zone `accessMap` that has existed since the directive was introduced makes the intended behavior unambiguous: each zone declared in the block should carry its own access setting. Scope the parser variables to the args loop so the misuse cannot recur, track the zones declared in the current `azure` directive, and apply `access` to all of them. The existing tests only checked that `parse()` did not error, which is why this defect went unnoticed. The new cases assert `accessMap` contents directly. Signed-off-by: James Raphael Tiovalen <jamestiotio@meta.com>
yongtang
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
access privatewas silently honored only for the last zone in anazure RG:ZONEblock. The earlier zones retained the defaultpublicmode and were queried against the wrong Azure API, returning empty or stale data without any error or warning. This affects the canonical multi-zone example shown in the README.The cause was a pair of function-scoped
resourceGroup/zoneNamevariables that the args loop overwrites on each iteration. Theaccesshandler then keyedaccessMapby whatever value happened to be left behind. The per-zoneaccessMapthat has existed since the directive was introduced makes the intended behavior unambiguous: each zone declared in the block should carry its own access setting.Scope the parser variables to the args loop so the misuse cannot recur, track the zones declared in the current
azuredirective, and applyaccessto all of them. The existing tests only checked thatparse()did not error, which is why this defect went unnoticed. The new cases assertaccessMapcontents directly.2. Which issues (if any) are related?
None that I know of.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
I don't think so unless some system is relying on the buggy behavior.