plugin/file: trigger reload of zones based on mtime#8085
Merged
Conversation
Signed-off-by: Endre Szabo <git@end.re>
Signed-off-by: Endre Szabo <git@end.re>
yongtang
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
In some cases, zone files are generated by CI or similar pipelines and triggers. These zone files are then pushed to multiple nameserver instances working in a multi-master setup. In these cases, generating SOA records and updating the serial numbers is an additional burden.
This PR addresses this issue in these specific use cases by enabling the plugin to reload the zone after the file has been pushed to the nameservers.
I'm proud of how simple it was to implement this, and of the fact that it also performs better, as parsing of the zone file content will only happen if the mtime has advanced. This is an improvement on the classical approach, where the SOA serial number had to be extracted first at each reload interval.
2. Which issues (if any) are related?
Maybe #528 is related to this one.
3. Which documentation changes (if any) need to be made?
Plugin documentation updated.
4. Does this introduce a backward incompatible change or deprecation?
Nope, it's backward compatible.