fix(auto): resolve symlinked directory before walk#8032
Merged
Conversation
When the `auto` plugin `directory` directive points to a symlink (e.g. a Kubernetes ConfigMap mount), the walk never enters the directory and no zone files are discovered. Reason is that `filepath.Walk` uses `os.Lstat` on the root path, which does not follow symlinks. Resolve the directory path with `filepath.EvalSymlinks` before each walk so that `filepath.Walk` sees a real directory. On failure the original path is used, preserving existing behavior. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
yongtang
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
When the
autoplugindirectorydirective points to a symlink (e.g. a Kubernetes ConfigMap mount), the walk never enters the directory and no zone files are discovered. Reason is thatfilepath.Walkusesos.Lstaton the root path, which does not follow symlinks.Resolve the directory path with
filepath.EvalSymlinksbefore each walk so thatfilepath.Walksees a real directory. On failure the original path is used, preserving existing behavior.The tests fail against
master:2. Which issues (if any) are related?
Fixes #8016
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No.