plugin/file: expand SVCB/HTTPS record support#7950
Merged
Conversation
Add proper SVCB (type 64) and HTTPS (type 65) handling: - Additional section processing: include A/AAAA glue for in-bailiwick SVCB/HTTPS targets, matching existing SRV/MX behavior - Target name normalization: lowercase SVCB/HTTPS Target on zone insert, consistent with CNAME/MX handling - Metrics: add TypeSVCB to monitored query types (TypeHTTPS was already present) - Test helpers: add SVCB()/HTTPS() constructors and Section comparison cases - Tests: basic queries with glue, AliasMode, wildcards, NoData, NXDOMAIN, target normalization, and DNS-AID private-use key (65400-65408) round-trip Signed-off-by: Ingmar <ivanglabbeek@infoblox.com>
thevilledev
requested changes
Mar 24, 2026
thevilledev
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the contribution! I'm just echoining a few minor linter issues, other than that it's good to go IMO.
dns.HTTPS embeds dns.SVCB, so .Target is directly accessible without the redundant .SVCB. qualifier. Fixes gosimple S1027. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ingmar <ivanglabbeek@infoblox.com>
Contributor
Author
|
Thanks for the review @thevilledev! Pushed c748f10 to simplify the HTTPS target access — using field promotion ( |
Collaborator
|
Hey @IngmarVG-IB, I can't see the commit in this branch. Can you double-check you pushed it to the right branch? |
Contributor
Author
|
Sorry about that @thevilledev — I pushed to the wrong fork remote. It should be visible now (c748f10). |
thevilledev
approved these changes
Mar 28, 2026
thevilledev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @IngmarVG-IB!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
CoreDNS currently parses SVCB (type 64) and HTTPS (type 65) records from zone files via miekg/dns, but the
fileplugin does not perform additional section processing or target normalization for them. This PR adds:plugin/file/lookup.go)plugin/file/zone.go)TypeSVCBto monitored query types;TypeHTTPSwas already present (plugin/metrics/vars/monitor.go)SVCB()/HTTPS()constructors andSection()comparison cases (plugin/test/helpers.go)plugin/file/svcb_test.go)2. Which issues (if any) are related?
None — this is a new feature contribution.
3. Which documentation changes (if any) need to be made?
None — no new Corefile syntax; existing zone file records just work correctly now.
4. Does this introduce a backward incompatible change or deprecation?
No. This is purely additive. Existing SVCB/HTTPS records in zone files were already parsed; they now get proper glue and normalization treatment.