Fix for misleading SOA parser warnings#7774
Merged
Merged
Conversation
70db174 to
70b7db2
Compare
thevilledev
requested changes
Dec 20, 2025
Signed-off-by: Ross Golder <ross@golder.org>
Signed-off-by: Ross Golder <ross@golder.org>
…ix gofmt Signed-off-by: Ross Golder <ross@golder.org>
61452e4 to
123021e
Compare
Contributor
Author
Thanks for the rapid response. Changes made as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
I was investigating an issue where what appeared to be valid zone files were being rejected with a 'missing SOA' error. The SOA was present and looked legitimate (to me, at least!). I was scratching my until I realised that it wasn't actually missing, it was just malformed because I'd gone over the 32bit uint limit. The error message was misleading.
2. Which issues (if any) are related?
N/A
3. Which documentation changes (if any) need to be made?
N/A
4. Does this introduce a backward incompatible change or deprecation?
No.