Skip to content

plugin/nomad: Support service filtering#7724

Merged
thevilledev merged 1 commit into
coredns:masterfrom
olljanat:nomad-service-filter
Nov 25, 2025
Merged

plugin/nomad: Support service filtering#7724
thevilledev merged 1 commit into
coredns:masterfrom
olljanat:nomad-service-filter

Conversation

@olljanat

@olljanat olljanat commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

1. Why is this pull request needed and what does it do?

Allow user to use filters like Tags not contains candidate which are useful example with Blue/Green deployments.

When canary_tags is provided in service registrations this:

service {
  name = "example"
  provider = "nomad"
  address_mode = "driver"
  canary_tags = [
    "candidate"
  ],
  tags = [
    "traefik.enable=true",
    "traefik.http.routers.example.entrypoints=web",
    "traefik.http.routers.example.rule=PathPrefix(`/`)"
  ]
}

tags defined in tags will be listed only in already promoted services so new container versions will be started in parallel but they will not get any traffic before promotion.

2. Which issues (if any) are related?

N/A

3. Which documentation changes (if any) need to be made?

Readme updated.

4. Does this introduce a backward incompatible change or deprecation?

No

@olljanat
plugin/nomad: Support service filtering
ab6ede2 
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
thevilledev
thevilledev approved these changes Nov 25, 2025
View reviewed changes

@thevilledev thevilledev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thevilledev thevilledev merged commit bdc03ed into coredns:master Nov 25, 2025
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thevilledev thevilledev thevilledev approved these changes

@bradbeam bradbeam Awaiting requested review from bradbeam bradbeam is a code owner

@chrisohaver chrisohaver Awaiting requested review from chrisohaver chrisohaver is a code owner

@dilyevsky dilyevsky Awaiting requested review from dilyevsky dilyevsky is a code owner

@jameshartig jameshartig Awaiting requested review from jameshartig jameshartig is a code owner

@greenpau greenpau Awaiting requested review from greenpau greenpau is a code owner

@Isolus Isolus Awaiting requested review from Isolus Isolus is a code owner

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric johnbelamaric is a code owner

@miekg miekg Awaiting requested review from miekg miekg is a code owner

@pmoroney pmoroney Awaiting requested review from pmoroney pmoroney is a code owner

@rajansandeep rajansandeep Awaiting requested review from rajansandeep rajansandeep is a code owner

@stp-ip stp-ip Awaiting requested review from stp-ip stp-ip is a code owner

@SuperQ SuperQ Awaiting requested review from SuperQ SuperQ is a code owner

@yongtang yongtang Awaiting requested review from yongtang yongtang is a code owner

@Tantalor93 Tantalor93 Awaiting requested review from Tantalor93 Tantalor93 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olljanat @thevilledev