perf(proxy): avoid unnecessary alloc in Yield#7708
Merged
Conversation
rdrozhdzh
reviewed
Nov 24, 2025
Currently, Yield allocates a new timer on every call via "time.After", even if the yield channel has space. This creates unnecessary heap allocations and GC pressure under load. This change adds a non-blocking select to try sending first, avoiding the timer allocation in the happy path. The timeout-based send is only used as a fallback when the receiver is not ready. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
dfda888 to
65228b4
Compare
yongtang
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Context is the
plugin/pkg/proxyhelper package, namely the persistent connection pool.Currently,
Yieldallocates a new timer on every call via "time.After", even if the yield channel has space. This creates unnecessary heap allocations and GC pressure under load.This change adds a non-blocking select to try sending first, avoiding the timer allocation in the happy path. The timeout-based send is only used as a fallback when the receiver is not ready.
Bench run showing the performance difference in "best case" scenario, where a timer allocation is not needed:
2. Which issues (if any) are related?
None.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No.