fix: correct spelling of MaximumDefaultTTL in cache and dnsutil packages#7678
Merged
Conversation
rdrozhdzh
reviewed
Nov 14, 2025
rdrozhdzh
left a comment
Collaborator
There was a problem hiding this comment.
please update the PR description accordingly
Member
|
@tsolodov Can you also fix the DCO errors as was mentioned https://github.com/coredns/coredns/pull/7678/checks?check_run_id=55371029286 |
Signed-off-by: Timur Solodovnikov <tsolodov@gmail.com>
f28f038 to
220f156
Compare
Contributor
Author
fixed, PTAL |
yongtang
approved these changes
Nov 18, 2025
rdrozhdzh
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Fixing a typo in constant name
2. Which issues (if any) are related?
There was a "TODO" comment on source code -
// TODO: rename as MaximumDefaultTTL3. Which documentation changes (if any) need to be made?
N/A
4. Does this introduce a backward incompatible change or deprecation?
Yes, we’re keeping the old constant with deprecation notice for backward compatibility