fix(multisocket): cap num sockets to prevent OOM#7615
Merged
johnbelamaric merged 1 commit intoOct 14, 2025
Conversation
Add hard maximum to number of sockets in the multisocket plugin. Unbounded value could cause CoreDNS to attempt creating an excessive number of listeners, leading to OOM at startup. Capping at 1024 mitigates misconfiguration while accomodating large environments. Add tests. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7615 +/- ##
==========================================
+ Coverage 55.70% 62.60% +6.90%
==========================================
Files 224 278 +54
Lines 10016 18573 +8557
==========================================
+ Hits 5579 11627 +6048
- Misses 3978 6259 +2281
- Partials 459 687 +228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johnbelamaric
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Add hard maximum to number of sockets in the multisocket plugin. Unbounded value could cause CoreDNS to attempt creating an excessive number of listeners, leading to OOM at startup. Capping at 1024 mitigates misconfiguration while accomodating large environments. Add tests.
2. Which issues (if any) are related?
Fixes OSS-Fuzz finding #451334054 (not publicly accessible).
3. Which documentation changes (if any) need to be made?
Added hard limit to documentation.
4. Does this introduce a backward incompatible change or deprecation?
Sets a sane maximum value for pathological input. Open to other views here.