plugin/import: add high caps for snippet/file import#7567
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7567 +/- ##
==========================================
+ Coverage 55.70% 62.39% +6.68%
==========================================
Files 224 274 +50
Lines 10016 18325 +8309
==========================================
+ Hits 5579 11433 +5854
- Misses 3978 6225 +2247
- Partials 459 667 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To fix Corefile related import cycle issue. Update docs. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
65eabde to
b851c6b
Compare
yongtang
approved these changes
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
To fix Corefile related import cycle issue. See coredns/caddy#8 and coredns/caddy#9 for further information. Fixed in coredns/caddy v1.1.3.
2. Which issues (if any) are related?
Fixes OSS-Fuzz #42486385. I ran the reproducer locally to validate.
3. Which documentation changes (if any) need to be made?
Added docs about the import limit.
4. Does this introduce a backward incompatible change or deprecation?
See above. The import limit is arbitrary but generous. Worth noting that a glob pattern counts as one. Importing a directory that has any number of configuration is fine.