plugin/metrics: add timeouts to metrics HTTP server#7469
Merged
yongtang merged 1 commit intocoredns:masterfrom Aug 29, 2025
Merged
plugin/metrics: add timeouts to metrics HTTP server#7469yongtang merged 1 commit intocoredns:masterfrom
yongtang merged 1 commit intocoredns:masterfrom
Conversation
Add ReadTimeout, WriteTimeout, and IdleTimeout (5s each) to metrics HTTP server and test to verify timeout behavior prevents hanging connections. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7469 +/- ##
==========================================
+ Coverage 55.70% 59.89% +4.19%
==========================================
Files 224 274 +50
Lines 10016 18140 +8124
==========================================
+ Hits 5579 10865 +5286
- Misses 3978 6637 +2659
- Partials 459 638 +179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thevilledev
commented
Aug 23, 2025
Comment on lines
+103
to
+105
| ReadTimeout: 5 * time.Second, | ||
| WriteTimeout: 5 * time.Second, | ||
| IdleTimeout: 5 * time.Second, |
Collaborator
Author
There was a problem hiding this comment.
These are static configs with IMO sensible defaults. I didn't see much benefit to make these configurable for a metrics endpoint. Happy to hear feedback and thoughts!
Member
There was a problem hiding this comment.
Yes I think we can hardcode for now. If there is really great need of parameterize then it can be added later.
yongtang
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
Add ReadTimeout, WriteTimeout, and IdleTimeout (5s each) to metrics HTTP server and test to verify timeout behavior prevents hanging connections.
2. Which issues (if any) are related?
None.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
No.