Skip to content

Add support for fallthrough to the grpc plugin#7359

Merged
yongtang merged 1 commit into
coredns:masterfrom
blakebarnett:grpc_plugin_fallthrough
Jun 6, 2025
Merged

Add support for fallthrough to the grpc plugin#7359
yongtang merged 1 commit into
coredns:masterfrom
blakebarnett:grpc_plugin_fallthrough

Conversation

@blakebarnett

Copy link
Copy Markdown
Contributor

Fixes: #7358

Fixes: coredns#7358
Signed-off-by: Blake Barnett <bbarnett@groq.com>
@blakebarnett blakebarnett force-pushed the grpc_plugin_fallthrough branch from b1c2dd1 to 82abf59 Compare June 5, 2025 22:34
@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.90%. Comparing base (93c57b6) to head (82abf59).
Report is 1491 commits behind head on master.

Files with missing lines Patch % Lines
plugin/grpc/grpc.go 6.66% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7359      +/-   ##
==========================================
+ Coverage   55.70%   59.90%   +4.20%     
==========================================
  Files         224      273      +49     
  Lines       10016    17931    +7915     
==========================================
+ Hits         5579    10741    +5162     
- Misses       3978     6565    +2587     
- Partials      459      625     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yongtang yongtang merged commit 6cba588 into coredns:master Jun 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Add fallthrough support to gRPC plugin

2 participants