Port to AWS Go SDK v2#6588
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6588 +/- ##
==========================================
+ Coverage 55.70% 59.95% +4.25%
==========================================
Files 224 273 +49
Lines 10016 18008 +7992
==========================================
+ Hits 5579 10796 +5217
- Misses 3978 6581 +2603
- Partials 459 631 +172 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, Is there any plans to merge this PR? |
|
@dilyevsky - Is it possible to please expedite the PR review? We are waiting for the release. |
|
Can we fix the merge conflicts ? @skitt |
|
Testing these changes - This can be fixed by passing an env variable |
There was a problem hiding this comment.
Can we use IMDS to get the AWS_REGION if the region flag is not set ?
if cfg.Region == "" {
imdsClient := imds.NewFromConfig(cfg)
region, err := imdsClient.GetRegion(ctx, &imds.GetRegionInput{})
if err != nil {
return nil, log.Fatalf("failed to get region from IMDS: %v", e)
}
cfg.Region = r.Region
}
The reason being SDK v1 used to have a default fallback region (aws global partition), which no longer exists in sdk v2. So unsuspecting users of this plugin who have not been setting a region flag will start seeing failures post upgrade..
There was a problem hiding this comment.
Thanks for looking into this, I’ll update the PR when I return from PTO next week.
v1 is deprecated, and support will end a little over a year from now. This ports the route53 plugin to v2. The major difference is that listing resource records no longer uses a callback function; the results are retrieved directly, but paging has to be handled by the caller. Signed-off-by: Stephen Kitt <skitt@redhat.com>
1. Why is this pull request needed and what does it do?
v1 is deprecated, and support will end a little over a year from now. This ports the route53 plugin to v2.
The major difference is that listing resource records no longer uses a callback function; the results are retrieved directly, but paging has to be handled by the caller.
2. Which issues (if any) are related?
None.
3. Which documentation changes (if any) need to be made?
None.
4. Does this introduce a backward incompatible change or deprecation?
None.