Do not link libraries in coqnative.#14540
Merged
coqbot-app[bot] merged 1 commit intorocq-prover:masterfrom Jun 29, 2021
Merged
Conversation
This is not actually required since we never evaluate any native program. The only thing that the native compiler needs to correctly perform the compilation is the association dirpath → file prefix. We explictly register this instead of going through the linking phase.
Member
Author
|
This is basically ready and needs an assignee. @ejgallego ? |
ejgallego
approved these changes
Jun 29, 2021
Contributor
ejgallego
left a comment
There was a problem hiding this comment.
Seems to work, and does provide a nice speed-up.
Contributor
|
@coqbot: merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not actually required since we never evaluate any native program. The only thing that the native compiler needs to correctly perform the compilation is the association dirpath → file prefix. We explictly register this instead of going through the linking phase.