Skip to content

bug: unifiedlog: flush closed sections behind open prefix#943

Merged
gbin merged 4 commits into
masterfrom
gbin/mmap-early-flush
Mar 21, 2026
Merged

bug: unifiedlog: flush closed sections behind open prefix#943
gbin merged 4 commits into
masterfrom
gbin/mmap-early-flush

Conversation

@gbin

@gbin gbin commented Mar 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

In the unified logger, a long lived open section could prevent the flush of the rest of an entire slab. Originally we never had long lived sections but with the keyframes that changed the constraints.

This changes track that and flush sections independently instead of by just trascking a global index on the slab.

This was creating a random flush spike.

Related issues

  • Closes #

Changes

Testing

  • just fmt
  • just lint
  • just test
  • optional full just std-ci (if std/runtime paths are impacted)
  • optional full just nostd-ci (if embedded/no_std paths are impacted)
  • Other (please specify):

pro-tip: just with no parameters in the root defaults to just fmt, just lint, and just test.

Checklist

  • I have updated docs or examples where needed
  • I have added or updated tests where needed
  • I have considered platform impact (Linux/macOS/Windows/embedded)
  • I have considered config/logging changes (if applicable)
  • This change is not a breaking change (or I documented it below)

Breaking changes (if any)

Additional context

@gbin gbin added bug Something isn't working include in changelog labels Mar 21, 2026
@gbin gbin merged commit 260f92c into master Mar 21, 2026
23 checks passed
@gbin gbin deleted the gbin/mmap-early-flush branch March 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant