Bug: Downstream timings not updated on bridges#847
Merged
Conversation
I realized that because with the new bridges logmon started to log 0us latency
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes bridge Tx timing metadata so downstream monitors (e.g., logmon) no longer see zero/incorrect latency for bridge transmit steps.
Changes:
- Derive macro now identifies the BridgeTx step’s output message slot and stamps
metadata.process_time.start/endon that output slot instead of the input message.
Comments suppressed due to low confidence (1)
core/cu29_derive/src/lib.rs:4455
process_time.endis currently stamped after the error-handling block, which means the measured range includes monitoring/decision logic (and inAbort/Shutdownbranches it may never be stamped due to early returns). To keep BridgeTx timings comparable to BridgeRx (which stampsendimmediately afterreceive), stampendright afterbridge.send(...)returns and before anymonitor.process_error(...)handling.
cumsg_output.metadata.process_time.start = clock.now().into();
let maybe_error = {
#rt_guard
bridge.send(
clock,
&<#bridge_type as cu29::cubridge::CuBridge>::Tx::#const_ident,
&*cumsg_input,
)
};
if let Err(error) = maybe_error {
let decision = monitor.process_error(#monitor_index, CuTaskState::Process, &error);
match decision {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that because with the new bridges logmon started to log 0us latency
Summary
Related issues
Changes
Testing
just fmtjust lintjust testjust std-ci(if std/runtime paths are impacted)just nostd-ci(if embedded/no_std paths are impacted)pro-tip:
justwith no parameters in the root defaults tojust fmt,just lint, andjust test.Checklist
Breaking changes (if any)
Additional context