Skip to content

fix: ROS2 zenoh attachement format#838

Merged
gbin merged 1 commit into
copper-project:masterfrom
kamibo:cb/fix-ros2-zenoh-attachement
Feb 16, 2026
Merged

fix: ROS2 zenoh attachement format#838
gbin merged 1 commit into
copper-project:masterfrom
kamibo:cb/fix-ros2-zenoh-attachement

Conversation

@kamibo

@kamibo kamibo commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Serialization format has changed.
ros2/rmw_zenoh#601

Related issues

  • Closes #

Changes

Testing

  • just fmt
  • just lint
  • just test (got some issues)
  • optional full just std-ci (if std/runtime paths are impacted)
  • optional full just nostd-ci (if embedded/no_std paths are impacted)
  • Other (please specify):

pro-tip: just with no parameters in the root defaults to just fmt, just lint, and just test.

Checklist

  • I have updated docs or examples where needed
  • I have added or updated tests where needed
  • I have considered platform impact (Linux/macOS/Windows/embedded)
  • I have considered config/logging changes (if applicable)
  • This change is not a breaking change (or I documented it below)

Breaking changes (if any)

Additional context

Serialization format has changed.
ros2/rmw_zenoh#601
@github-actions

Copy link
Copy Markdown

Hi! Thanks for opening this pull request.

Because this is your first time contributing to this repository, please read our contributor guide:
https://github.com/copper-project/copper-rs/blob/master/CONTRIBUTING.md

@gbin gbin added bug Something isn't working labels Feb 16, 2026

@makeecat makeecat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we recognize it as a breaking change?

@gbin

gbin commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

@makeecat pure bug on my part:
rmw_zenoh_cpp models the attachment as AttachmentData(sequence_number, source_timestamp, source_gid) with those three fields stored as members and serialized together and not a list of key/value

I will push a patch version.

@gbin gbin merged commit 623dee2 into copper-project:master Feb 16, 2026
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants