fix: default LinuxResources points to non existent devices#809
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 198f46a3cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gbin
left a comment
There was a problem hiding this comment.
thanks! with a couple nits
| id: "msp_bridge", | ||
| type: "cu_msp_bridge::CuMspBridgeStd", | ||
| resources: { serial: "linux.serial_usb0" }, | ||
| resources: { serial: "linux.serial3" }, |
There was a problem hiding this comment.
what do you suggest to do here? Is that an acknowledgment that this one is good here?
There was a problem hiding this comment.
yep the id is linux, which makes sense in the context :) but still move it to the common doc form the bundle
…g documentation from CRSF and MSP
gbin
left a comment
There was a problem hiding this comment.
please move the msp doc too
| id: "msp_bridge", | ||
| type: "cu_msp_bridge::CuMspBridgeStd", | ||
| resources: { serial: "linux.serial_usb0" }, | ||
| resources: { serial: "linux.serial3" }, |
There was a problem hiding this comment.
yep the id is linux, which makes sense in the context :) but still move it to the common doc form the bundle
I believe they have already been moved in 64618ba |
Summary
fix the bug that default LinuxResources points to non existent devices introduced by PR: #790
Related issues
Changes
converting errors to strings via .to_string())
Testing
just std-cijust lintcargo +stable nextest run --workspace --all-targetsChecklist