Skip to content

fix: add output getters for bridges in sim mode#788

Merged
gbin merged 1 commit into
masterfrom
matthew_a/fix/add-bridge-output-getters
Feb 6, 2026
Merged

fix: add output getters for bridges in sim mode#788
gbin merged 1 commit into
masterfrom
matthew_a/fix/add-bridge-output-getters

Conversation

@matthewashton-k

@matthewashton-k matthewashton-k commented Feb 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Normal tasks have helper methods to get their outputs from a copperlist when you re simulate, but the bridge tasks didn't have that yet.

Changes

  • added bridge_specs as a param to gen_culist_support
  • used bridge specs in gen_culist_support to make the getters in the same way its done for other tasks

Testing

  • just std-ci
  • just lint
  • cargo +stable nextest run --workspace --all-targets
  • Other: Tested the getters in my own project

Checklist

  • I have updated docs or examples where needed
  • I have added or updated tests where needed
  • I have considered platform impact (Linux/macOS/Windows/embedded)
  • I have considered config/logging changes (if applicable)
  • This change is not a breaking change (or I documented it below)

Breaking changes (if any)

N/A

@matthewashton-k matthewashton-k requested a review from gbin February 5, 2026 20:23
@matthewashton-k matthewashton-k changed the title fix: add getters for bridges in sim mode fix: add output getters for bridges in sim mode Feb 5, 2026
@gbin gbin self-assigned this Feb 5, 2026
@gbin gbin added bug Something isn't working include in changelog labels Feb 5, 2026
@makeecat

makeecat commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gbin gbin merged commit 74f7817 into master Feb 6, 2026
24 of 25 checks passed
@gbin gbin deleted the matthew_a/fix/add-bridge-output-getters branch February 6, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants