Fix: terminal not properly restored on exit + strerr bombing prevention.#73
Merged
Conversation
…ld be fixing the corruptions from stderr and retoring the terminal.
Collaborator
|
Just pulled this down and tested it out on my laptop running fedora + bash in the vscode integrated terminal. Exit works well now! I did test out |
mik90
approved these changes
Oct 24, 2024
| let dev_null_fd = dev_null.as_raw_fd(); | ||
| let original_stderr_fd = unsafe { dup(2) }; | ||
| unsafe { | ||
| dup2(dev_null_fd, 2); |
Collaborator
There was a problem hiding this comment.
Does the libc create have a constant for stderr or do you have to use 2? If not, could be good to use a var to denote that. I had to double check https://en.wikipedia.org/wiki/File_descriptor
Collaborator
Author
There was a problem hiding this comment.
ha yes, libc::STDERR_FILENO it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terminal issues became a huge pain with the simulators. This should be fixing the corruptions from stderr and retoring the terminal.