[FEAT] dag-logstats#691
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 600236dbcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let duration_secs = duration_ns as f64 / 1_000_000_000.0; | ||
| let intervals = (self.valid_time_samples - 1) as f64; | ||
| ( | ||
| Some(intervals / duration_secs), | ||
| Some(self.total_raw_bytes as f64 / duration_secs), |
There was a problem hiding this comment.
Exclude untimestamped bytes from throughput
When some outputs have a payload but no process_time.end, record_sample still adds their bytes to total_raw_bytes, yet throughput here divides by a duration derived only from the subset with valid end times. In logs where valid_time_samples < samples, this inflates throughput_bytes_per_sec (and can mislead downstream visualization) because bytes that lack a timestamp are counted against a shorter time window. Consider tracking bytes only for samples with end_time_ns or returning None when any timed data is missing.
Useful? React with 👍 / 👎.
|
it ... works :) just dag-logstats balancebot-logreader logs/balance_0.copper <- this is strange because the log reader takes logs/balance.copper and reads logs/balance_0.copper logs/balance_1.copper etc... (this is a little quirky). maybe put the entry in directly in the examples where we know the binary and name of the log etc.. it will be easier. The goal of justfiles for me is to exactly not have to remember complex command lines I have one bug: in chrome it doubles the pop up. And one improvement request: maybe put a visual cue like hover points in the games so you know you can hover over a link? |
…atching. Therefore channel-distinct edges no longer merge, with a fallback to channel-less keys for older logstats files
… is handled in one place
…he natiev tooltip alongside the custom one
All comments addressed |
Summary
Adds logstats export and DAG enrichment with hoverable edge stats/perf tables, plus example helpers and payload-size plumbing.
Related Issue: #684
Details
core/cu29_export/src/logstats.rsandcore/cu29_export/src/lib.rs.core/cu29_traits/src/lib.rsandcore/cu29_derive/src/lib.rs.--logstatsJSON, validate schema/signature/mission, and render edge tooltips + perf table with hover cues incore/cu29_runtime/src/rendercfg.rs,core/cu29_runtime/src/config.rs, andcore/cu29_runtime/Cargo.toml.dag-logstatshelpers andREADMEentries for balancebot and caterpillar examples inexamples/cu_rp_balancebot/justfile,examples/cu_caterpillar/justfile,examples/ cu_rp_balancebot/README.md, andexamples/cu_caterpillar/README.md..gitignore.