Skip to content

wrap recurring graph pattern as CuGraph helpers#611

Merged
makeecat merged 1 commit into
masterfrom
yang/feat/petgraph_abstraction
Jan 6, 2026
Merged

wrap recurring graph pattern as CuGraph helpers#611
makeecat merged 1 commit into
masterfrom
yang/feat/petgraph_abstraction

Conversation

@makeecat

@makeecat makeecat commented Jan 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Identified the recurring patterns (BFS traversal, edge iteration, edge-id lookup) and surfaced them as CuGraph helpers, then refactored runtime/monitoring/derive to consume the new API so petgraph stays internal.

address issue: #335

Details

  • Added CuGraph traversal/edge helpers (node_ids, edges, edge, edge_id_between, bfs_nodes) in core/cu29_runtime/src/config.rs to cover the patterns without exposing petgraph types.
  • Swapped runtime planning over to the new helpers (BFS traversal, edge lookup, neighbor enqueueing) in core/cu29_runtime/src/curuntime.rs.
  • Updated monitoring and codegen to iterate connections via graph.edges() instead of petgraph iterators in core/cu29_runtime/src/monitoring.rs and core/cu29_derive/src/lib.rs.

@makeecat

makeecat commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@makeecat makeecat added the enhancement New feature or request label Jan 6, 2026
@makeecat makeecat self-assigned this Jan 6, 2026
@makeecat makeecat requested a review from gbin January 6, 2026 02:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jan 6, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@gbin

gbin commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

OMG this is SO much better

@makeecat makeecat merged commit 692d378 into master Jan 6, 2026
17 of 18 checks passed
@makeecat makeecat deleted the yang/feat/petgraph_abstraction branch January 6, 2026 05:01
@makeecat makeecat mentioned this pull request Jan 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbin gbin gbin approved these changes

Assignees

@makeecat makeecat

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makeecat @gbin