Adds a way to disable logging for some tasks.#407
Merged
Conversation
gbin
commented
Jul 29, 2025
Collaborator
- Added a logging { enabled = false } entry to the ron file
- Generates the payload clears of the matching tasks on the runtime generation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to disable logging for specific tasks by introducing a logging configuration option. The implementation allows tasks to be marked with logging: { enabled: false } in the configuration file, which prevents their output payloads from being logged during runtime.
- Adds optional logging configuration to task nodes in the config system
- Modifies the runtime code generation to clear payloads for tasks with logging disabled
- Includes a complete example demonstrating the no-logging functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| examples/cu_nologging_tasks/* | Complete example project demonstrating disabled logging functionality |
| core/cu29_runtime/src/config.rs | Adds NodeLogging struct and logging configuration support to Node |
| core/cu29_derive/src/lib.rs | Implements runtime code generation for payload clearing based on logging settings |
| Cargo.toml | Adds the new example to workspace members |
Collaborator
Author
|
@matthewashton-k do you mind testing that on your project too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.