[CHORE] bump bevy to 0.16#303
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the bevy dependency to 0.16 and updates various examples, benchmarks, configuration files, and CI workflows for compatibility with the new Bevy release.
- Updated Cargo.toml files and dependencies to reflect bevy 0.16.
- Revised example code (custom collider, collision layers, chain_2d, ccd, etc.) and benchmark configurations to work with the updated Bevy APIs.
- Adjusted CI workflows and project metadata accordingly.
Reviewed Changes
Copilot reviewed 229 out of 232 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| patches/avian/crates/avian2d/examples/debugdump_2d.rs | Added placeholder example with a to‑do message. |
| patches/avian/crates/avian2d/examples/custom_collider.rs | Introduced a custom circle collider with updated scaling; minor typo exists in a comment. |
| patches/avian/crates/avian2d/examples/collision_layers.rs | Updated example for collision layers compatibility. |
| patches/avian/crates/avian2d/examples/chain_2d.rs | Added chaining example with joints. |
| patches/avian/crates/avian2d/examples/ccd.rs | Introduced a CCD example with updated configuration. |
| patches/avian/crates/avian2d/benches/pyramid.rs | Updated benchmarks for pyramid simulation with improved parameters. |
| patches/avian/crates/avian2d/Cargo.toml | Updated features and dependency versions for bevy 0.16. |
| patches/avian/README.md | Revised documentation to include new version details and examples. |
| patches/avian/Cargo.toml, .github workflows, and others | Updated workspace, CI/CD, and project configuration files for compatibility. |
| examples/cu_rp_balancebot/* | Updated example code and dependency version (from 0.15.3 to 0.16.0) for balancebot simulation. |
| Cargo.toml, .config/_typos.toml | Adjusted project-level configuration and patch settings. |
Files not reviewed (3)
- patches/avian/.gitignore: Language not supported
- patches/avian/LICENSE-APACHE: Language not supported
- patches/avian/LICENSE-MIT: Language not supported
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to use bevy 0.16 and updates related dependencies and APIs accordingly. Key changes include:
- Bumping bevy and related dependencies in Cargo.toml and updating their usage in code.
- Integrating an improved asset caching mechanism with a fallback to offline mode.
- Adapting API usage and error handling in various systems (e.g., asset loading, query handling).
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/cu_rp_balancebot/src/world/mod.rs | Updates to asset caching (using online/offline caches), improved error logging, and replacing tuple insertions with a CartBundle. |
| examples/cu_rp_balancebot/src/sim.rs | Updates to query error handling with expect() and added unapproved_path_mode for the AssetPlugin. |
| examples/cu_rp_balancebot/Cargo.toml | Bump of bevy version to 0.16 and dependency source updates for upstream packages. |
| Cargo.toml | Patch applied for cached-path dependency. |
| .config/_typos.toml | Added configuration to exclude patches from typo analysis. |
Comments suppressed due to low confidence (1)
examples/cu_rp_balancebot/src/world/mod.rs:199
- Using unwrap() on the result of .parent() may lead to a panic if the parent path is None. Consider handling this case more gracefully, for example by providing a fallback or an error message.
let balance_bot_path = balance_bot_hashed.parent().unwrap().join(BALANCEBOT);
69f2483 to
db357b7
Compare
db357b7 to
60158cc
Compare
This was referenced Apr 30, 2025
Closed
Collaborator
Author
|
We will merge this PR after the release of v0.8.0, to wait for the dependency maintainer to update Bevy to 0.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions:
cu-rp-balancebotexampleiyes_perf_uifor supporting bevy 0.16avian3d0.3.0 to support bevy 0.16.cached-path0.6.2 to fix offline loading cached assetcu-rp-balancebot. The previous version will crash the example if the device does not have internet access/Actions:
1. Monitor https://github.com/Jondolf/avian to wait for 0.3.0 update to officially support bevy 0.162. Monitor https://github.com/IyesGames/iyes_perf_ui to wait for 0.5.0 update to officially support bevy 0.16
3. Monitor https://github.com/epwalsh/rust-cached-path to wait for 0.6.2 update to address PR: epwalsh/rust-cached-path#78 or PR: epwalsh/rust-cached-path#74