Skip to content

Bug fixes and cleanups for balancebot sim#137

Merged
gbin merged 3 commits into
masterfrom
gbin/balancebot-cleanup
Dec 5, 2024
Merged

Bug fixes and cleanups for balancebot sim#137
gbin merged 3 commits into
masterfrom
gbin/balancebot-cleanup

Conversation

@gbin

@gbin gbin commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@gbin

gbin commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

@Nashenas88 actually it was needed :)... because we have a race condition spawning the entities vs the resources loading. I added a boolean flag to not recreate the entities once they are build.

Do you mind checking if that restores the fps on your side too? Thanks

@gbin

gbin commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator Author

@Nashenas88 actually it was needed :)...

I consistently get 60fps+ on my small integrated graphics laptop. 👍
Also with the perf-ui feature flag I added, you can see that the entities count stay the same ;)

@gbin gbin merged commit c5a3440 into master Dec 5, 2024
@gbin gbin deleted the gbin/balancebot-cleanup branch December 5, 2024 21:56
@Nashenas88

Nashenas88 commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

The updated version works. Thanks!

@makeecat makeecat added the bug Something isn't working label Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants