Removes the lifecycle trait#115
Merged
Merged
Conversation
mik90
approved these changes
Nov 28, 2024
mik90
left a comment
Collaborator
There was a problem hiding this comment.
Flattening the hierarchy makes sense, this makes it easier to read
| where | ||
| Self: Sized; | ||
|
|
||
| /// Start is called once for a long period of time. |
Collaborator
There was a problem hiding this comment.
This comment was there beforehand, but what does "long period of time" entail. Like it's allowed/expected to take a long time?
It split artificially the implementation of tasks and couples the passed types.
bcad913 to
2d3e998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It split artificially the implementation of tasks and couples the passed types.