Fix cliUrl to auto-correct useStdio for backend service scenarios#97
Merged
brunoborges merged 1 commit intomainfrom Feb 9, 2026
Merged
Fix cliUrl to auto-correct useStdio for backend service scenarios#97brunoborges merged 1 commit intomainfrom
brunoborges merged 1 commit intomainfrom
Conversation
When cliUrl is set (connecting to an external CLI server), useStdio is now automatically set to false since TCP is inherently required. Previously, users had to explicitly call setUseStdio(false) alongside setCliUrl(), which contradicted the setup.md documentation. Also simplified CliServerManager.connectToServer to be parameter-driven rather than flag-driven, and updated tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nWhen
cliUrlis set (connecting to an external CLI server),useStdiois now automatically set tofalsesince TCP is inherently required.\n\nPreviously, users had to explicitly callsetUseStdio(false)alongsidesetCliUrl(), which contradicted thesetup.mddocumentation that shows:\n\njava\nvar options = new CopilotClientOptions()\n .setCliUrl(\"localhost:4321\");\n\n\n## Changes\n\n- CopilotClient: Auto-correctsuseStdiotofalsewhencliUrlis provided. Simplified mutual exclusion validation to only rejectcliUrl+cliPath.\n- CliServerManager: MadeconnectToServerparameter-driven (routes by host/port availability) instead of flag-driven.\n- CopilotClientTest: Updated tests for new behavior, addedtestCliUrlAutoCorrectsUseStdioandtestCliUrlOnlyConstruction.\n\n## Testing\n\nAll 14CopilotClientTesttests pass. Full test suite passes (1 pre-existing unrelated E2E failure inSessionEventsE2ETest).