make umbrella and its documentation really optional#2217
Merged
btovar merged 2 commits intocooperative-computing-lab:masterfrom Dec 9, 2019
Merged
make umbrella and its documentation really optional#2217btovar merged 2 commits intocooperative-computing-lab:masterfrom
btovar merged 2 commits intocooperative-computing-lab:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr #2211 brought attention to the fact that the umbrella documentation was not optional. This pr makes it so that if the documentation for umbrella cannot be build, then the installation does not fail.
In the very near future we should do something in the spirit of #2211, and detect the pydoc corresponding to the correct python environment. I would like to this using python itself, rather than what we currently do, which is manipulating names for a command line which will eventually break.