Skip to content

Give access to Jinja2 environment variables#946

Closed
ramnes wants to merge 3 commits intocookiecutter:masterfrom
numberly:jinja2-environment
Closed

Give access to Jinja2 environment variables#946
ramnes wants to merge 3 commits intocookiecutter:masterfrom
numberly:jinja2-environment

Conversation

@ramnes
Copy link
Copy Markdown
Contributor

@ramnes ramnes commented May 15, 2017

See the rationale behind this PR: #637 (comment)

This PR fixes #704.

@ramnes
Copy link
Copy Markdown
Contributor Author

ramnes commented Jul 4, 2017

@hackebrot gentle ping on that one also. 😉

@ramnes
Copy link
Copy Markdown
Contributor Author

ramnes commented Jul 11, 2018

@hackebrot @pydanny yearly ping

@ramnes
Copy link
Copy Markdown
Contributor Author

ramnes commented Jul 27, 2018

Note for myself: as discussed together with @hackebrot at the EuroPython, the problem here is that StrictEnvironment is used at several places, and not only for the file generation; and for example, in prompt_for_config, we don't want that the environment given affects the current behavior. We might want to put the logic directly in generate_files rather than the context.

@hackebrot hackebrot added the enhancement This issue/PR relates to a feature request. label Aug 15, 2018
@ramnes
Copy link
Copy Markdown
Contributor Author

ramnes commented Mar 30, 2019

@hackebrot I've finally updated this PR so that it is just as we discussed at the EuroPython last year! It should be simpler to review that way, I hope you'll find a few minutes for this. 🙏

@con-f-use
Copy link
Copy Markdown

Yearly ping again.

@cookiecutter cookiecutter deleted a comment from codecov-io May 30, 2020
@cookiecutter cookiecutter deleted a comment from codecov-io May 30, 2020
@insspb
Copy link
Copy Markdown
Member

insspb commented May 30, 2020

@con-f-use Yearly ping. haha :)

@insspb insspb added this to the 2.0.0 milestone May 30, 2020
@insspb insspb self-assigned this May 30, 2020
@insspb insspb added feature This issue/PR relates to major feature request. and removed enhancement This issue/PR relates to a feature request. labels May 30, 2020
@insspb
Copy link
Copy Markdown
Member

insspb commented May 30, 2020

Hi @ramnes, @con-f-use
Thank you for contribution.
Unfortunately I have no access to original branch, so I restored it in PR #1419
This branch is closed as outdated.
Feature will be merged to master soon, and expected to be in cookiecutter 2.0

@insspb insspb closed this May 30, 2020
@srchulo
Copy link
Copy Markdown

srchulo commented Sep 23, 2020

@insspb thanks for doing this! Do you know if 2.0 will be released soon? I would really love to use this to change variable_start_string and variable_end_string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This issue/PR relates to major feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jinja2 environment settings

5 participants