Skip to content

Added: Path templates will be rendered when copy_without_render used#839

Merged
insspb merged 1 commit intocookiecutter:masterfrom
noirbizarre:render_copy_without_render
May 29, 2020
Merged

Added: Path templates will be rendered when copy_without_render used#839
insspb merged 1 commit intocookiecutter:masterfrom
noirbizarre:render_copy_without_render

Conversation

@noirbizarre
Copy link
Copy Markdown
Contributor

@noirbizarre noirbizarre commented Oct 23, 2016 •
edited
Loading

This pull-request ensures paths variables are rendered when using _copy_without_render.

It should fix #456.

It does not keep the existing behavior as it was inconsistent, different for files and directories (matched files had their path rendered but not the matched directories).
If this behavior should be kept, I'll update this pull-request with a boolean option like _copy_without_render_paths.

@noirbizarre noirbizarre force-pushed the render_copy_without_render branch from 09ed9a3 to 0e4a9b8 Compare January 22, 2017 23:52
@noirbizarre
Copy link
Copy Markdown
Contributor Author

noirbizarre commented Jan 22, 2017

Any chance to see that one merged ? It would be great !!!
Should I change something ? ...
Any comment, any review, I'll update so it can be merge 👍

@noirbizarre
Copy link
Copy Markdown
Contributor Author

noirbizarre commented Mar 26, 2017

Hi !
@pydanny @audreyr @michaeljoseph @pfmoore @hackebrot 👋
I never had any feedback on this. As this a this a really simple fix to a really annoying issue (to me), I just want to know:

  • is there something I need to change ?
  • will this be merged ?
  • If not, why ?

Any review, any comment, I'll make the changes ASAP !

@theodesp
Copy link
Copy Markdown

theodesp commented Aug 8, 2017

I think it looks good @noirbizarre

@michaeljoseph michaeljoseph requested a review from hackebrot August 9, 2017 19:17
michaeljoseph
michaeljoseph approved these changes Aug 9, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaeljoseph michaeljoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, nice fix 😸

@michaeljoseph
Copy link
Copy Markdown
Contributor

michaeljoseph commented Aug 11, 2017

@noirbizarre could we please have a small update to the docs to include a note about the path vs file content behaviour of this functionality.
Perhaps with an explanatory example?

@noirbizarre noirbizarre force-pushed the render_copy_without_render branch from 0e4a9b8 to b0d7235 Compare September 22, 2017 10:39
@noirbizarre
Copy link
Copy Markdown
Contributor Author

noirbizarre commented Sep 22, 2017 •
edited
Loading

Done.
@michaeljoseph @theodesp Sorry for the late response, I just noticed yours

@noirbizarre noirbizarre force-pushed the render_copy_without_render branch from b0d7235 to 93a55d4 Compare September 22, 2017 10:41
hackebrot
hackebrot previously requested changes Sep 22, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@hackebrot hackebrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you 🙇

Minor docs fix.

@hackebrot
Copy link
Copy Markdown
Member

hackebrot commented Sep 22, 2017

I wonder if we should treat this as a breaking change... 🤔

@audreyr @pydanny @michaeljoseph

@noirbizarre noirbizarre force-pushed the render_copy_without_render branch from 93a55d4 to d6df586 Compare September 25, 2017 14:07
@noirbizarre
Copy link
Copy Markdown
Contributor Author

noirbizarre commented Sep 25, 2017

I fixed the typo.

My opinion: I don't think this should be considered as a breaking change but as a fix because the previous behavior was inconsistent (different behavior for files and directories) and unless you are making a meta cookiecutter (ie. a cookiecutter template rendering cookiecutter templates), I don't think there is any reason to render brackets into path (which was the behavior for directories before this fix because path variables were not rendered).

@noirbizarre
Copy link
Copy Markdown
Contributor Author

noirbizarre commented May 2, 2018

@audreyr @pydanny @michaeljoseph @theodesp @hackebrot
Could this be merged before the 1.7 is released ?

@insspb insspb added this to the 2.0.0 milestone May 28, 2020
@insspb insspb added breaking-change Marks an important and likely breaking change. Require update for major version feature This issue/PR relates to major feature request. labels May 28, 2020
@insspb insspb self-assigned this May 28, 2020
@cookiecutter cookiecutter deleted a comment from codecov-io May 28, 2020
@insspb insspb force-pushed the render_copy_without_render branch from d6df586 to 840844d Compare May 28, 2020 23:58
@insspb insspb changed the title Render path templates in copy_without_render Added: Path templates will be rendered when copy_without_render used May 29, 2020
@insspb insspb merged commit d7e7b28 into cookiecutter:master May 29, 2020
@insspb
Copy link
Copy Markdown
Member

insspb commented May 29, 2020

@noirbizarre Thank you for contribution. Nothing lost. Merged after 4 year in queue :)

@noirbizarre noirbizarre deleted the render_copy_without_render branch June 22, 2020 23:41
@simobasso simobasso mentioned this pull request May 15, 2021
Closed
@newlog
Copy link
Copy Markdown

newlog commented Jul 4, 2021

Thanks for this change.

@namco1992 namco1992 mentioned this pull request Jul 8, 2022
Merged
5 tasks
@mbonnefoy mbonnefoy mentioned this pull request Oct 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hackebrot hackebrot hackebrot left review comments

+2 more reviewers

@michaeljoseph michaeljoseph michaeljoseph approved these changes

@insspb insspb insspb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@insspb insspb

Labels

breaking-change Marks an important and likely breaking change. Require update for major version feature This issue/PR relates to major feature request.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

Allow for copy_without_render to render output directory name

6 participants

@noirbizarre @theodesp @michaeljoseph @hackebrot @insspb @newlog