Closed
Conversation
|
Coverage increased (+0.14%) when pulling 026cd288496137a99e2b0f412de270e1c8281839 on dnephin:rich_context into 376316c on audreyr:master. |
026cd28 to
655f790
Compare
1 similar comment
Author
|
Also resolves #126 |
Contributor
|
👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #30
This change maintains backwards compatibility with the old format, so a context version isn't really necessary (although it wouldn't hurt if the context supported it).
Currently only supports one
typeof boolean, so that context parameters can be used inifblocks. Without this support you can't really have a default ofTrue, and have the user enterFalse(because any value the user enters would beTrue. I suspect there will be other types that can be added here.