Skip to content

Hackebrot convert test config#345

Merged
pydanny merged 14 commits intocookiecutter:masterfrom
hackebrot:hackebrot-convert-test-config
Mar 14, 2015
Merged

Hackebrot convert test config#345
pydanny merged 14 commits intocookiecutter:masterfrom
hackebrot:hackebrot-convert-test-config

Conversation

@hackebrot
Copy link
Copy Markdown
Member

Convert TestGetConfig, TestGetConfigWithDefaults and TestGetUserConfig to py.test using fixtures for the existing setup/teardown code.

While implementing back_up_rc I noticed that the former unittest.TestCase does not remove any ~/.cookiecutterrc that the tests create. I did not change this behaviour in the re-implementation. Please let me know if I shall add this clean-up.

Cheers! 🙇

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling c809921 on hackebrot:hackebrot-convert-test-config into 376316c on audreyr:master.

@michaeljoseph
Copy link
Copy Markdown
Contributor

👍 and yeah, let's add a teardown.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a864c6b on hackebrot:hackebrot-convert-test-config into 376316c on audreyr:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling a864c6b on hackebrot:hackebrot-convert-test-config into 376316c on audreyr:master.

@hackebrot
Copy link
Copy Markdown
Member Author

An additional teardown removes the rc created by the tests a864c6b

Currently the original ~/.cookiecutter.rc is deleted by running the complete suite due to the missing super teardown in test_main.py. My re-implementation (#332, #334) takes care of it.

This is something to verify in the course of #343

@pydanny pydanny merged commit a864c6b into cookiecutter:master Mar 14, 2015
This was referenced Mar 15, 2015
@hackebrot hackebrot deleted the hackebrot-convert-test-config branch March 20, 2015 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants