Merged
Conversation
939407e to
255cb5d
Compare
Contributor
|
This one needs manual conflict resolution. |
633a5c2 to
4e5de99
Compare
Contributor
Author
that should do it! failing CI jobs due to #2063 |
for more information, see https://pre-commit.ci
89da7f2 to
90d49c6
Compare
kurtmckee
suggested changes
Jul 3, 2024
kurtmckee
approved these changes
Jul 3, 2024
jensens
approved these changes
Jul 4, 2024
Contributor
Author
|
the ubuntu 3.7 job will need to be removed as an 'expected check' in the repo config |
danieleades
commented
Jul 7, 2024
| logger.debug('Writing contents to file %s', outfile) | ||
|
|
||
| with open(outfile, 'w', encoding='utf-8', newline=newline) as fh: | ||
| with open(outfile, 'w', encoding='utf-8', newline=newline) as fh: # noqa: FURB103 (false positive for python < 3.10) |
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.