run mypy on tests directory#2059
Merged
jensens merged 6 commits intocookiecutter:mainfrom Apr 18, 2024
Merged
Conversation
9fb47a0 to
1d33e55
Compare
Contributor
Author
|
remaining errors are due to this monstrosity: def run_pre_prompt_hook(repo_dir: Path | str) -> Path | str:
"""Run pre_prompt hook from repo directory.
:param repo_dir: Project template input directory.
"""
# Check if we have a valid pre_prompt script
with work_in(repo_dir):
scripts = find_hook('pre_prompt')
if not scripts:
return repo_dir
# Create a temporary directory
repo_dir = create_tmp_repo_dir(repo_dir)
with work_in(repo_dir):
scripts = find_hook('pre_prompt') or []
for script in scripts:
try:
run_script(script, str(repo_dir))
except FailedHookException as e: # noqa: PERF203
raise FailedHookException('Pre-Prompt Hook script failed') from e
return repo_dirwhich sometimes returns a there are places in the codebase where it fails if it doesn't return a |
danieleades
commented
Apr 7, 2024
6 tasks
Contributor
|
@danieleades well, somethings wrong after rebase/conflict solving? Any idea? |
Contributor
Author
I'll take a look this evening! |
Contributor
Author
|
@jensens should be good now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.