Merged
Conversation
Contributor
Author
|
working on this PR highlighted the highly inconsistent use of file paths in this repo, which switches pretty loosely between |
7398604 to
91c9474
Compare
Contributor
Author
|
@jensens this is ready for review |
jensens
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a minimal mypy linting configuration
Rather than attempt to completely resolve all type errors in this repo in one go, i've opted to fix the obvious ones and whitelist the rest. Over time, this whitelist should be shrunk and eventually removed entirely.