Skip to content

Fix regression #2009: Adding value to nested dicts broken#2010

Merged
jensens merged 7 commits intomainfrom
fix-2009
Feb 21, 2024
Merged

Fix regression #2009: Adding value to nested dicts broken#2010
jensens merged 7 commits intomainfrom
fix-2009

Conversation

@jensens
Copy link
Copy Markdown
Contributor

@jensens jensens commented Feb 2, 2024

See #2009

@jensens jensens added bug This issue/PR relates to a bug. regression A feature used to work in past and is now broken or gone. labels Feb 2, 2024
Adding value to nested dicts broken after 2.2.0
@jensens
Copy link
Copy Markdown
Contributor Author

jensens commented Feb 2, 2024

Test coverage fails in Python 3.7 to 3.9, but it is covered in 3.10 upwards.

A local tox -e py37 show the same result. Fun part: If I put a breakpoint() in between of the (according to pytest-cov) non-covered lines, I run into it.

I have no idea what happens here.

Any ideas?

@jensens jensens marked this pull request as ready for review February 19, 2024 17:46
@jensens jensens requested review from ericof and kurtmckee February 19, 2024 17:47
jensens and others added 2 commits February 20, 2024 10:16
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
@jensens jensens requested a review from kurtmckee February 21, 2024 16:24
@jensens jensens merged commit 35f6f2b into main Feb 21, 2024
@jensens jensens deleted the fix-2009 branch February 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue/PR relates to a bug. regression A feature used to work in past and is now broken or gone.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants